-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add identifier and schema to get_relation_last_modified
macro
#274
base: main
Are you sure you want to change the base?
fix: Add identifier and schema to get_relation_last_modified
macro
#274
Conversation
@xcezz Hey! |
some additional context: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I see in this PR's CI run that this actually solves one of our known failures in the tests. Could you also please update .github/expected_failures
by removing:
tests/functional/adapter/relation/test_get_relation_last_modified.py::TestGetLastRelationModified::test_get_last_relation_modified
Thanks :)
@xcezz Hey! Have you already signed CLA? Our colleagues haven't received any new CLA signs yet. |
I thought I had already done that. I've just signed it again! |
Summary
The
get_relation_last_modified
macro currently returns an invalid data structure, causing compilation errors when runningdbt source freshness
.This PR adds identifier and schema columns and keeps the existing data structure expected by dbt.
Description
After updating
dbt
anddbt-dremio
from 1.7 to 1.8, I noticed that freshness checks no longer work:After reading dbt-labs/dbt-core#8307, especially looking at the
get_relation_last_modified
reference implementation from Snowflake, I noticed we don't returnschema
andidentifier
With this change,
dbt source freshness
returns proper freshness information without compilation errors.Test Results
Changelog
Related Issue