Skip to content

Commit

Permalink
refactor(docker): remove placeholder image names (#1077)
Browse files Browse the repository at this point in the history 
Motivation
----------
The `image` in a `docker-compose.yml` is not required.
If you want to build the docker image from the `Dockerfile` you can simply add a build context.

How to test
-----------
1. `docker image rm` all the dreammall images
2. `docker compose up`
3. All images get rebuilt
  • Loading branch information
@roschaefer
roschaefer authored Jul 1, 2024
1 parent 682bd91 commit cdd9e15
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 33 deletions.
26 changes: 1 addition & 25 deletions docker-compose.override.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ services:
# PRESENTER ############################################
########################################################
presenter:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/presenter:local-development
build:
target: development
ports:
Expand All @@ -31,8 +29,6 @@ services:
# PRESENTER STORYBOOK #################################
#######################################################
presenter-storybook:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/presenter:local-storybook
build:
context: ./presenter
target: storybook
Expand All @@ -51,8 +47,6 @@ services:
# PRESENTER DOCUMENTATION #############################
#######################################################
presenter-documentation:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/presenter:local-documentation
build:
context: ./presenter
target: documentation
Expand All @@ -71,8 +65,6 @@ services:
# FRONTEND #############################################
########################################################
frontend:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/frontend:local-development
build:
target: development
ports:
Expand All @@ -92,8 +84,6 @@ services:
# FRONTEND STORYBOOK ##################################
#######################################################
frontend-storybook:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/frontend:local-storybook
build:
context: ./frontend
target: storybook
Expand All @@ -112,8 +102,6 @@ services:
# FRONTEND DOCUMENTATION ##############################
#######################################################
frontend-documentation:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/frontend:local-documentation
build:
context: ./frontend
target: documentation
Expand All @@ -132,8 +120,6 @@ services:
# ADMIN ################################################
########################################################
admin:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/admin:local-development
build:
target: development
ports:
Expand All @@ -153,8 +139,6 @@ services:
# ADMIN STORYBOOK #####################################
#######################################################
admin-storybook:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/admin:local-storybook
build:
context: ./admin
target: storybook
Expand All @@ -173,8 +157,6 @@ services:
# ADMIN DOCUMENTATION #################################
#######################################################
admin-documentation:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/admin:local-documentation
build:
context: ./admin
target: documentation
Expand All @@ -193,8 +175,6 @@ services:
# BACKEND #############################################
#######################################################
backend:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/backend:local-development
build:
context: ./backend
target: development
Expand All @@ -211,8 +191,6 @@ services:
# BACKEND DOCUMENTATION ###############################
#######################################################
backend-documentation:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/backend:local-documentation
build:
context: ./backend
target: documentation
Expand All @@ -231,8 +209,6 @@ services:
# DOCUMENTATION ########################################
########################################################
documentation:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/dreammall:local-documentation
build:
target: documentation
ports:
Expand All @@ -258,4 +234,4 @@ volumes:
admin_documentation_node_modules:
backend_node_modules:
backend_documentation_node_modules:
documentation_node_modules:
documentation_node_modules:
8 changes: 0 additions & 8 deletions docker-compose.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ services:
# PRESENTER ############################################
########################################################
presenter:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/presenter:local-production
build:
context: ./presenter
target: production
Expand All @@ -39,8 +37,6 @@ services:
# FRONTEND #############################################
########################################################
frontend:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/frontend:local-production
build:
context: ./frontend
target: production
Expand All @@ -56,8 +52,6 @@ services:
# ADMIN ################################################
########################################################
admin:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: dreammall/admin:local-production
build:
context: ./admin
target: production
Expand All @@ -73,8 +67,6 @@ services:
# BACKEND #############################################
#######################################################
backend:
# name the image so that it cannot be found in a DockerHub repository, otherwise it will not be built locally from the 'dockerfile' but pulled from there
image: it4c/backend:local-production
build:
context: ./backend
target: production
Expand Down

0 comments on commit cdd9e15

Please sign in to comment.