You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The log statements which notify state changes are not correct, there seems to be an issue with the (order of the) arguments passed to the notify function. Looks like the first argument being passed is self.
Summary
The log statements which notify state changes are not correct, there seems to be an issue with the (order of the) arguments passed to the notify function. Looks like the first argument being passed is self.
On this line, https://github.com/dream11/lua-circuit-breaker/blob/master/src/breaker.lua#L134, the notify function should be called like this
self.notify(cb_name, new_state)
Also, there should be a check if notify is nil or not since there is no default value.
The text was updated successfully, but these errors were encountered: