Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10.2 and Swift 5. #4

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Xcode 10.2 and Swift 5. #4

merged 4 commits into from
Apr 10, 2019

Conversation

lm2343635
Copy link
Contributor

@lm2343635 lm2343635 commented Mar 27, 2019

  • Fix the build warning after Xcode 10.2.
  • Update to Swift 5.

Screen Shot 2019-03-27 at 16 31 17

@lm2343635
Copy link
Contributor Author

This warning happens on Xcode 10.2

@lm2343635
Copy link
Contributor Author

Hi @dqhieu
Can you merge this PR and update the CocoaPods version.
Thank you very much!

@lm2343635 lm2343635 changed the title Fix the build warning. Xcode 10.2 and Swift 5. Mar 28, 2019
@fishcharlie
Copy link

@lm2343635 Are you getting the following error? It doesn't look like this section got updated in your PR.

Screen Shot 2019-03-30 at 10 36 39 AM

@lm2343635
Copy link
Contributor Author

Hi, @fishcharlie
Have you updated to the latest version?
https://github.com/dqhieu/UIGradient/blob/master/Sources/UIGradientHelper.swift

@fishcharlie
Copy link

@lm2343635 Nope. Not on master. On the latest CocoaPods version.

@lm2343635
Copy link
Contributor Author

lm2343635 commented Apr 1, 2019

@fishcharlie
It seems that the author @dqhieu has not updated the CocoaPods version. 😢

@dqhieu
Copy link
Owner

dqhieu commented Apr 1, 2019

Hi, sorry guys I was very busy last week. I will try to merge and update the CocoaPods version this week. Thank you guys very much for helping me keep this library up to date 👍

@fishcharlie
Copy link

@dqhieu Any updates on this?

@dqhieu
Copy link
Owner

dqhieu commented Apr 10, 2019

I'm working on it now

@dqhieu dqhieu merged commit 4efe3c7 into dqhieu:master Apr 10, 2019
@dqhieu
Copy link
Owner

dqhieu commented Apr 10, 2019

Updated guys. Thanks for your help. I am very appreciated. 🙇🏻‍♂️

@lm2343635
Copy link
Contributor Author

Why do you updated your minimum deployment target to 11.0?

@lm2343635
Copy link
Contributor Author

lm2343635 commented Apr 10, 2019

I mean the minimum deployment target in the podspec file.
Many projects are based on 9.0 and 10.0

Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "UIGradient":
  In Podfile:
    UIGradient (~> 1.3)

Specs satisfying the `UIGradient (~> 1.3)` dependency were found, but they required a higher minimum deployment target.

@dqhieu
Copy link
Owner

dqhieu commented Apr 10, 2019

@lm2343635 I will revert this change, sorry for that

@dqhieu
Copy link
Owner

dqhieu commented Apr 10, 2019

Done @lm2343635 , please use version 1.3.1. Thanks 🙇

@lm2343635
Copy link
Contributor Author

Thanks! @dqhieu

@dqhieu
Copy link
Owner

dqhieu commented Apr 15, 2019

Hi guys, if you need any improvement or feature request feel free to comment in this issue: #7
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants