Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageManager improvements #61

Merged
merged 7 commits into from
Dec 31, 2023
Merged

Conversation

LupertEverett
Copy link
Contributor

@LupertEverett LupertEverett commented Dec 30, 2023

  • PackageManager now uses GameLaunchInfo directly, and it has additional helper functions for checking which game we're running (IsDeusEx(), IsUnrealTournament(), etc.)
  • PackageManager now uses the Paths keys inside the ini file for determining the paths it should check for packages. It also checks the PackageRemap keys when available, though I'm unsure about whether the remapping I'm doing is correct or not here.
  • Disabled getting some properties of the TcpLink class when the game is Unreal Gold version 226, as they crashed the engine due to them apparently not existing. The game now launches on Linux (same caveats mentioned in readme apply), but crashes on Windows still for some reason.
  • Additional functions are added into FilePath and IniFile classes for implementing the above changes.

@dpjudas dpjudas merged commit 94d3ea1 into dpjudas:master Dec 31, 2023
4 checks passed
@dpjudas
Copy link
Owner

dpjudas commented Dec 31, 2023

Very nice! About the TcpLink stuff, the properties and native functions change over time between the different games.

This is because they just kept coding on the engine and each game is a snapshot of the engine look at that exact moment in time. Functions and properties got removed, others got added, and in some rare cases they aren't entirely compatible with each other.

@Xaleros has been working on improving the cmdlets we have for extracting the native functions and properties from a game so that they output into a json format that we can then use to auto-generate C++ code that is doing some code ala what you had to do there with TcpLink.

Since you both seem to be working on improving support for more game versions maybe we need to talk about this some more - otherwise one of you risk end up doing stuff that is incompatible with what the other is doing. Do you use Discord by any chance? Xalaros has an Unreal Multiplayer server where we have a dev channel for Surreal Engine.

@LupertEverett
Copy link
Contributor Author

Yeah the TcpLink stuff makes sense.

Also was aware of Xaleros's recent work, though I didn't realize that our works were somewhat overlapping. Joining to the discord server sounds like a good idea, I already have an account there, and coordinating our works would be for the better.

@LupertEverett LupertEverett deleted the packagemanager branch December 31, 2023 11:22
@LupertEverett
Copy link
Contributor Author

Speaking of which, where can I find the said server? My searches didn't result in anything.

If you need to contact me there for the server link instead, my @ at there is the same with here.

@Xaleros
Copy link
Contributor

Xaleros commented Jan 2, 2024

Sent you a friend request on discord, let me know if you didn't get it, otherwise i'll send you an invite to the server there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants