Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge AudioSubsystem into USurrealAudioDevice #157

Merged
merged 9 commits into from
Jan 26, 2025

Conversation

LupertEverett
Copy link
Contributor

@LupertEverett LupertEverett commented Jan 24, 2025

This PR moves ALL functionality in AudioSubsystem to USurrealAudioDevice. This both unifies the AudioSubsystems, and makes the sound and music sliders in settings finally work (the issue was the settings were saved to USurrealAudioDevice, which did pretty much nothing; and AudioSubsystem was actually handling all the sound playing stuff)

Some details about the movearound:

  • distSquared(vec3, vec3) function in AudioSubsystem.cpp is now moved to vec.h file, where it makes more sense
  • USurrealAudioDevice has InitDevice() and ShutdownDevice() functions to handle the initialization and destruction of the device. The latter was added because SurrealEngine would crash during shut down otherwise.

Known bugs:

  • Turning down the sound volume will also turn down the music volume. I've no idea why that happens.

@dpjudas dpjudas merged commit b83a268 into dpjudas:master Jan 26, 2025
4 checks passed
@LupertEverett LupertEverett deleted the single_audio_subsystem branch January 26, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants