Merge AudioSubsystem into USurrealAudioDevice #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves ALL functionality in
AudioSubsystem
toUSurrealAudioDevice
. This both unifies the AudioSubsystems, and makes the sound and music sliders in settings finally work (the issue was the settings were saved toUSurrealAudioDevice
, which did pretty much nothing; andAudioSubsystem
was actually handling all the sound playing stuff)Some details about the movearound:
distSquared(vec3, vec3)
function in AudioSubsystem.cpp is now moved to vec.h file, where it makes more senseUSurrealAudioDevice
hasInitDevice()
andShutdownDevice()
functions to handle the initialization and destruction of the device. The latter was added because SurrealEngine would crash during shut down otherwise.Known bugs: