-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Layout): add SidebarMinWidth/SidebarMaxWidth parameter #5452
Conversation
Reviewer's Guide by SourceryThis pull request introduces No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The attribute name
ShowSplitBar
is misspelled asShowSplitebar
in the code, please fix it. - Consider adding a default value for
SidebarMinWidth
andSidebarMaxWidth
to avoid unexpected behavior when they are not explicitly set.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5452 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 646 646
Lines 29350 29352 +2
Branches 4129 4129
=========================================
+ Hits 29350 29352 +2 ☔ View full report in Codecov by Sentry. |
add SidebarMinWidth/SidebarMaxWidth parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5451
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds
SidebarMinWidth
,SidebarMaxWidth
, andShowSplitbar
parameters to the Layout component to allow specifying the minimum and maximum width of the sidebar and showing a split bar between the sidebar and the main content.New Features:
SidebarMinWidth
andSidebarMaxWidth
parameters to the Layout component to allow specifying the minimum and maximum width of the sidebar.ShowSplitbar
parameter to the Layout component to allow showing a split bar between the sidebar and the main content.Tests:
SidebarMinWidth
andSidebarMaxWidth
parameters are rendered correctly.