Adding simsun-extg font to support more character #10517
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
dipeshmsft
reviewed
Feb 27, 2025
| @@ -1716,8 +1716,11 @@ | |||
| --> | |||
| <!-- CHS --> | |||
| <FontFamilyMap | |||
| Unicode = "20000-2A6DF" | |||
| Language = "zh-Hans" | |||
There was a problem hiding this comment.
Do we need to remove the above unicodes for it to work ? Can't we add to it ?
There was a problem hiding this comment.
Its not removed. We have added a new font Simsun-ExtG and modified the unicode range for Simsun-ExtB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Simsun-ExtG font and modifying the character range for the Simsun-ExtB font to GlobalUserInterface composite font. This will enable us to support more character from GB18030.
Customer Impact
all the characters will be displayed correctly, without this many of the Chinese characters will be displayed as boxes.
Regression
NA
Testing
In progress
Risk
Low
Microsoft Reviewers: Open in CodeFlow