Make Dynamic Resource Optmization as Opt-Int #10516
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
pchaurasia14
approved these changes
Feb 27, 2025
|
@batzen Are there any news regarding the new approach you had planned? |
|
@h3xds1nz will create a PR during the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10491
Description
As in .NET 9, the changes here makes DynamicResource Optimization as opt-in. As observed in some of the SyncFusion based sample applications, the optimized resources, causes crashing apps. The reason we are keeping this as opt-in is to accommodate fixes in the optimized approach. We will look into other options if we are unable to fix it at a later point.
Regression
Yes
Testing
Local Build Pass
Sample application testing
Risk
Low, changing things back to pre .NET 9 behavior
cc:/ @batzen
Microsoft Reviewers: Open in CodeFlow