Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish Code Coverage for wpf #10514

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Establish Code Coverage for wpf #10514

merged 5 commits into from
Feb 27, 2025

Conversation

singhashish-wpf
Copy link
Member

@singhashish-wpf singhashish-wpf commented Feb 27, 2025

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR establishes code coverage reporting for WPF by introducing a new codecov configuration and integrating coverage reporting into the CI pipeline.

  • Added a codecov.yml configuration file with detailed coverage thresholds and flag definitions.
  • Updated README.md to include a codecov badge for production coverage.
  • Modified eng/pipeline-pr.yml to pass coverage parameters through build and test steps and to upload coverage data.

Reviewed Changes

File Description
codecov.yml New configuration for code coverage thresholds and flags.
README.md Added a codecov badge linking to coverage reports.
eng/pipeline-pr.yml Updated pipeline tasks to include coverage parameters and upload.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

codecov.yml:14

  • Verify that the pattern 'eng/::/' is correctly formatted for its intended purpose, as it may not match the desired paths.
    - "eng/::/"

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@034ce35). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10514   +/-   ##
==========================================
  Coverage        ?   10.99998%           
==========================================
  Files           ?        3215           
  Lines           ?      648474           
  Branches        ?       71534           
==========================================
  Hits            ?       71332           
  Misses          ?      576143           
  Partials        ?         999           
Flag Coverage Δ
Debug 10.99998% <100.00000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@singhashish-wpf singhashish-wpf merged commit 7481b7e into main Feb 27, 2025
5 of 8 checks passed
@singhashish-wpf singhashish-wpf deleted the codecov branch February 27, 2025 12:11
'`' /*96*/, '|' /*124*/, '~' /*126*/,
];

private static ReadOnlySpan<char> AllowedCharacters => s_allowedCharacters;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed? Makes no sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants