Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force an x64 runtime install #10494

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Feb 24, 2025

Works around an issue where because WPF uses Platform globally as to mean the Target platform, and because this is a default property that arcade uses to install additional runtimes, arcade installs the arm64 runtime on an x64 machine, which breaks when we try to run msbuild in signing. It would also break things if we ever ran testing.

<PropertyGroup>
    <Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
    <Platform Condition="'$(Platform)' == ''">AnyCPU</Platform>
    <PlatformName Condition="'$(PlatformName)' == ''">$(Platform)</PlatformName>
  </PropertyGroup>
Microsoft Reviewers: Open in CodeFlow

ViktorHofer
ViktorHofer previously approved these changes Feb 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 24, 2025
@akoeplinger
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

The x86 tests fail with

xUnit.net Console Runner v2.9.2+82543a6df6 (64-bit .NET 10.0.0-preview.2.25121.10)
System.IO.FileLoadException: Could not load file or assembly 'D:\a_work\1\s\artifacts\bin\System.Xaml.Tests\x86\Debug\net10.0\System.Xaml.Tests.dll'. The assembly architecture is not compatible with the current process architecture.
=== COMMAND LINE ===
"D:\a_work\1\s.dotnet\dotnet.exe" exec --depsfile "D:\a_work\1\s\artifacts\bin\System.Xaml.Tests\x86\Debug\net10.0\System.Xaml.Tests.deps.json" --runtimeconfig "D:\a_work\1\s\artifacts\bin\System.Xaml.Tests\x86\Debug\net10.0\System.Xaml.Tests.runtimeconfig.json" "D:\a_work\1\s.packages\xunit.runner.console/2.9.2/tools/netcoreapp2.0/xunit.console.dll" "D:\a_work\1\s\artifacts\bin\System.Xaml.Tests\x86\Debug\net10.0\System.Xaml.Tests.dll" -noautoreporters -xml "D:\a_work\1\s\artifacts\TestResults\Debug\System.Xaml.Tests_net10.0_x86.xml" -html "D:\a_work\1\s\artifacts\TestResults\Debug\System.Xaml.Tests_net10.0_x86.html" > "D:\a_work\1\s\artifacts\log\Debug\System.Xaml.Tests_net10.0_x86.log" 2>&1

@mmitche
Copy link
Member Author

mmitche commented Feb 24, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmitche mmitche merged commit 2242372 into dotnet:release/10.0-preview2 Feb 24, 2025
8 checks passed
@pchaurasia14
Copy link
Member

@mmitche - Does this need to go in main too?

@akoeplinger
Copy link
Member

@pchaurasia14 yes it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants