Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run DesignTimeMarkupCompilation when DesignTimeBuild is set. #10489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run DesignTimeMarkupCompilation when DesignTimeBuild is set. #10489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<PropertyGroup>
<!-- Add Markup compilation to the CoreCompileDependsOn so that the IDE inproc compilers (particularly VB)
can "see" the generated source files. -->
<CoreCompileDependsOn Condition="'$(BuildingInsideVisualStudio)' == 'true' ">
<CoreCompileDependsOn Condition="'$(BuildingInsideVisualStudio)' == 'true' Or '$(DesignTimeBuild)' == 'true'">
DesignTimeMarkupCompilation;
$(CoreCompileDependsOn)
</CoreCompileDependsOn>
Expand All @@ -88,7 +88,7 @@

<Target Name="DesignTimeMarkupCompilation">
<!-- Only if we are not actually performing a compile i.e. we are in design mode -->
<CallTarget Condition="'$(BuildingProject)' != 'true' Or $(DesignTimeBuild) == 'true'"
<CallTarget Condition="'$(BuildingProject)' != 'true' Or '$(DesignTimeBuild)' == 'true'"
Targets="MarkupCompilePass1" />
</Target>

Expand Down