[Cleanup] Use named arguments in PresentationCore #10321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Automated changes. Contributes to dotnet#10018
Manual changes. Contributes to dotnet#10018
ThomasGoulet73
force-pushed
the
cleanup-use-named-arguments-in-PresentationCore
branch
from
e206b7f to
1f182b1
Compare
|
I rebased on main to fix the conflicts. |
himgoyalmicro
added
Included in test pass
Status:InProgress
Status:Completed
and removed
Queue for test pass
Status:InProgress
labels
|
Many thanks to @ThomasGoulet73 for your relentless contributions. Your hard work is greatly appreciated! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10018
Description
I replaced comments specifying an argument name with named arguments, which were introduced in C# 7. This improves readability and maintainability.
My changes are in 2 commits the first commit is automated changes using regexes and the second commit is manual changes where the comment is outdated or formatted differently than the parameter name.
Note: The compiled IL is identical.
(Except for some of the changes in Visual.cs where I renamed some parameters e -> args to better reflect the parameter and be able to remove the comment)
Customer Impact
None.
Regression
No.
Testing
Local build + validated IL.
Risk
Low to none.
Microsoft Reviewers: Open in CodeFlow