Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fluent ] Fix TabControl Style #10498

Open
dipeshmsft opened this issue Feb 25, 2025 · 1 comment
Open

[ Fluent ] Fix TabControl Style #10498

dipeshmsft opened this issue Feb 25, 2025 · 1 comment

Comments

@dipeshmsft
Copy link
Member

dipeshmsft commented Feb 25, 2025

Description

This is a subissue to track the progress of TabControl Style fix.

Here are the broad categories of tasks that need to be done for this:

  1. Match resource usage in control styles with WinUI resources where possible
  2. Add animations for controls where required to match WinUI.
  3. Compare Fluent styles with Aero2 styles to match
    3.a. Properties like HorizontalAlignment, VerticalAlignment
    3.b. TemplateBinding comparison with Aero2 styles
  4. Compare WPF Fluent styles with WinUI styles :
    4.a. Convert ControlTemplate Triggers to VisualStates ( to simplify animation's and bring parity with WinUI styles )
    4.b. Convert StaticResource's to DynamicResource for properties where customization is needed.
    4.c. Define resources for CornerRadius, Thickness, etc. for the controls where it is needed

Links of related open TabControl Issues

@dipeshmsft dipeshmsft changed the title • [TabControl](https://learn.microsoft.com/en-us/dotnet/api/system.windows.controls.tabcontrol) [ Fluent ] Fix TabControl Style Feb 25, 2025
@andreaCosm
Copy link

As requested, copying note over from #10393

Thank you for your efforts, just found this ticket while trying to understand the new Fluent controls, having just switched to the newest version of WPF. I want single out that the tab control needs better states and contrast. There's no hover animation; the selection also doesn't seem update the color with selection either although I do see that working in the example. Are we supposed to use a specific background color with it?

Image

                    <TabControl>
                        <TabItem Header="Audio">
                            <TextBlock Text="Audio Settings" VerticalAlignment="Center" HorizontalAlignment="Center"/>
                        </TabItem>
                        <TabItem Header="Video">
                            <TextBlock Text="Video Settings" VerticalAlignment="Center" HorizontalAlignment="Center"/>
                        </TabItem>
                    </TabControl>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants