From 0d79e6de8dbc26a44dde336a9a680940e92e9904 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 5 Aug 2024 11:10:48 -0700 Subject: [PATCH] Fix DAC stack overflow in GetUsefulGlobals API (#105962) Co-authored-by: Mike McLaughlin --- src/coreclr/debug/daccess/request.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/coreclr/debug/daccess/request.cpp b/src/coreclr/debug/daccess/request.cpp index 3731f9ad799a8..b4de3332da23f 100644 --- a/src/coreclr/debug/daccess/request.cpp +++ b/src/coreclr/debug/daccess/request.cpp @@ -2408,7 +2408,7 @@ ClrDataAccess::GetMethodTableForEEClass(CLRDATA_ADDRESS eeClassReallyCanonMT, CL } else { - hr = GetMethodTableForEEClassImpl (eeClassReallyCanonMT, value); + hr = GetMethodTableForEEClassImpl(eeClassReallyCanonMT, value); } SOSDacLeave(); return hr; @@ -3535,7 +3535,7 @@ ClrDataAccess::GetUsefulGlobals(struct DacpUsefulGlobalsData* globalsData) hr = m_cdacSos->GetUsefulGlobals(globalsData); if (FAILED(hr)) { - hr = GetUsefulGlobals(globalsData); + hr = GetUsefulGlobalsImpl(globalsData); } #ifdef _DEBUG else @@ -3554,7 +3554,7 @@ ClrDataAccess::GetUsefulGlobals(struct DacpUsefulGlobalsData* globalsData) } else { - hr = GetUsefulGlobals(globalsData);; + hr = GetUsefulGlobalsImpl(globalsData);; } SOSDacLeave();