Make frozen doc state non-nullable #77896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Trying something out to see if it cleans up compilation tracker state management. |
CyrusNajmabadi
changed the title
|
@dibarbet ptal. |
Comment on lines
141
to
142
| Contract.ThrowIfFalse(FrozenSourceGeneratedDocumentIdentities.HasValue); | ||
| Contract.ThrowIfFalse(FrozenSourceGeneratedDocuments.HasValue); |
There was a problem hiding this comment.
If these should now always have a value, should they become non-nullable too?
There was a problem hiding this comment.
So much simpler. Thanks!
davidwengier
approved these changes
Mar 31, 2025
| @@ -117,7 +117,7 @@ private SolutionCompilationState Branch( | |||
| SolutionState newSolutionState, | |||
| ImmutableSegmentedDictionary<ProjectId, ICompilationTracker>? projectIdToTrackerMap = null, | |||
| SourceGeneratorExecutionVersionMap? sourceGeneratorExecutionVersionMap = null, | |||
| Optional<TextDocumentStates<SourceGeneratedDocumentState>?> frozenSourceGeneratedDocumentStates = default, | |||
| Optional<TextDocumentStates<SourceGeneratedDocumentState>> frozenSourceGeneratedDocumentStates = default, | |||
There was a problem hiding this comment.
You don't need Optional here anymore.
There was a problem hiding this comment.
Good call. Simplifying.
| // For the frozen source generated document info, we expect two either have both checksum collections or neither, and they | ||
| // should both be the same length as there is a 1:1 correspondence between them. | ||
| Contract.ThrowIfFalse(frozenSourceGeneratedDocumentIdentities.HasValue == frozenSourceGeneratedDocuments.HasValue); | ||
| Contract.ThrowIfFalse(frozenSourceGeneratedDocumentIdentities?.Count == frozenSourceGeneratedDocuments?.Length); |
There was a problem hiding this comment.
Did you still want to keep this assertion that the lengths match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.