Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that newline is inserted after file scoped namespace declarations #77821

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Inurias
Copy link

@Inurias Inurias commented Mar 25, 2025

Fixes issue #67400

@Inurias Inurias requested a review from a team as a code owner March 25, 2025 23:07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 25, 2025
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Mar 25, 2025
@Inurias
Copy link
Author

Inurias commented Mar 25, 2025

@dotnet-policy-service agree

@Inurias
Copy link
Author

Inurias commented Mar 26, 2025

There are some tests failing that have code like this in their expected string:

namespace ConsoleApp185;
using System;
using System.Collections.Generic;

which would now be:

namespace ConsoleApp185;

using System;
using System.Collections.Generic;

How should these cases be handled? Do I update the expected strings in those tests?

@CyrusNajmabadi
Copy link
Member

o I update the expected strings in those tests?

Yup. We can review all the changes and make sure it matches our expectations. Thanks!

@Inurias
Copy link
Author

Inurias commented Mar 26, 2025

o I update the expected strings in those tests?

Yup. We can review all the changes and make sure it matches our expectations. Thanks!

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants