Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow CancellationToken more appropriately in lifecycle #9330

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Flow CancellationToken more appropriately in lifecycle #9330

merged 1 commit into from
Feb 9, 2025

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Feb 8, 2025 •
edited by dotnet-policy-service bot
Loading

  • Use WaitAsync where appropriate
  • Flow CancellationToken to Task.Delay when appropriate
  • Use SuppressThrowing when appropriate
  • Enable nullability in more places
Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond force-pushed the fix/ct-usage-in-lifecycle branch from 90230c9 to 43232a3 Compare February 9, 2025 16:43
@ReubenBond ReubenBond enabled auto-merge (squash) February 9, 2025 16:49
@ReubenBond ReubenBond merged commit 78ae8ce into dotnet:main Feb 9, 2025
34 of 35 checks passed
@ReubenBond ReubenBond deleted the fix/ct-usage-in-lifecycle branch February 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReubenBond