Revert "[Testing] Updated Appium.WebDriver to v7.0.0" #27498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a407b5f.
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj: Language not supported
- src/Controls/tests/TestCases.Mac.Tests/Controls.TestCases.Mac.Tests.csproj: Language not supported
- src/Controls/tests/TestCases.WinUI.Tests/Controls.TestCases.WinUI.Tests.csproj: Language not supported
- src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj: Language not supported
- src/TestUtils/src/UITest.Appium/UITest.Appium.csproj: Language not supported
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214_2.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/KeyboardScrolling.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214_3.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22715.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:1726
- Ensure that the behavior of the updated Unlock method is covered by tests.
app.CommandExecutor.Execute("unlock", ImmutableDictionary<string, object>.Empty);
| /// <exception cref="InvalidOperationException">Unlock is only supported on <see cref="AppiumAndroidApp"/>.</exception> | ||
| public static void Unlock(this IApp app, string unlockType = "", string unlockKey = "") | ||
| public static void Unlock(this IApp app) |
There was a problem hiding this comment.
The change in the Unlock method signature is a breaking change. Ensure that this change is documented and that the public docs are updated accordingly.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
I think we might not need this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27184