-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling more UI Tests by removing platform specific condition - 1 #27454
base: main
Are you sure you want to change the base?
[Testing] Enabling more UI Tests by removing platform specific condition - 1 #27454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 23 out of 38 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- src/Controls/tests/TestCases.HostApp/Issues/Issue19379.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue19877.xaml: Language not supported
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17865.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13616.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1426.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13551.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16094.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16918.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17366.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17400.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19556.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Issue1426.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19500.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18282.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19379.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18720DatePicker.cs
Outdated
Show resolved
Hide resolved
…andhan-rajagopal/maui into enable-xamarinuitest-harish29
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,4 @@ | |||
#if IOS | |||
using NUnit.Framework; | |||
using NUnit.Framework; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , added snapshot for Windows
@@ -17,13 +16,11 @@ public Issue19926(TestDevice device) | |||
[Category(UITestCategories.BoxView)] | |||
public async Task PropertiesShouldBeCorrectlyApplied() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending Windows snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , added snapshot for Windows
[Test] | ||
[Category(UITestCategories.Entry)] | ||
[Category(UITestCategories.Border)] | ||
public void BorderRoundRectangleWithImage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending Windows snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , added snapshot for Windows
@@ -1,5 +1,4 @@ | |||
#if IOS | |||
using NUnit.Framework; | |||
using NUnit.Framework; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending Windows snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , added snapshot for Windows
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -1,5 +1,4 @@ | |||
#if WINDOWS | |||
using NUnit.Framework; | |||
using NUnit.Framework; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing on Android. Small differences:
Probably because #27179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , I have updated the snapshot from the latest build
@@ -1,5 +1,4 @@ | |||
#if IOS | |||
using NUnit.Framework; | |||
using NUnit.Framework; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , I have updated the snapshot from the latest build.
@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition() | |||
VerifyScreenshot(); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , I have updated the snapshot from the latest build
@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition() | |||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz , I have updated the snapshot from the latest build
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 1st group of tests enabled.
Test Cases:
Fixes #22902