Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling more UI Tests by removing platform specific condition - 1 #27454

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Jan 29, 2025

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 1st group of tests enabled.

Test Cases:

  • Issue13551
  • Issue13616
  • Issue1426
  • Issue16094
  • Issue16918
  • Issue17366
  • Issue17400
  • Issue17865
  • Issue18282
  • Issue18720
  • Issue18720DatePicker
  • Issue18720TimePicker
  • Issue18720Editor
  • Issue1908
  • Issue19379
  • Issue19500
  • Issue19556
  • Issue19592
  • Issue19657
  • Issue19803
  • Issue19877
  • Issue19926
  • Issue20294

Fixes #22902

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 29, 2025
@anandhan-rajagopal anandhan-rajagopal added partner/syncfusion Issues / PR's with Syncfusion collaboration area-testing Unit tests, device tests labels Jan 30, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review January 30, 2025 06:25
@Copilot Copilot bot review requested due to automatic review settings January 30, 2025 06:25
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner January 30, 2025 06:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 38 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue19379.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/Issues/Issue19877.xaml: Language not supported
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17865.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13616.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1426.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13551.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16094.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16918.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17366.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17400.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19556.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.HostApp/Issues/Issue1426.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19500.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18282.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19379.cs: Evaluated as low risk

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these tests are failing because the snapshot is pending:
image
Could you commit the images?

@@ -1,5 +1,4 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Windows snapshot already available in the latest build.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , added snapshot for Windows

@@ -17,13 +16,11 @@ public Issue19926(TestDevice device)
[Category(UITestCategories.BoxView)]
public async Task PropertiesShouldBeCorrectlyApplied()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Windows snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , added snapshot for Windows

[Test]
[Category(UITestCategories.Entry)]
[Category(UITestCategories.Border)]
public void BorderRoundRectangleWithImage()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Windows snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , added snapshot for Windows

@@ -1,5 +1,4 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Windows snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , added snapshot for Windows

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jan 31, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing on Android. Small differences:
image
Probably because #27179

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , I have updated the snapshot from the latest build

@@ -1,5 +1,4 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also failing on Android:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , I have updated the snapshot from the latest build.

@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition()
VerifyScreenshot();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We improved the process of create the test snapshot. No longer take full screen app screenshots. This will require to update the Mac snapshots.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , I have updated the snapshot from the latest build

@@ -24,5 +23,4 @@ public void CarouselItemLoadsInCorrectPosition()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small differences on snapshots, failing on Android:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , I have updated the snapshot from the latest build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Review all (UI) Tests and remove platform-specific runs where possible
3 participants