Is Aspnetcore open to community perf improvements? #61794
Unanswered
TylerBurnett
asked this question in
Q&A
Replies: 1 comment 1 reply
-
https://www.igvita.com/2011/12/19/dont-push-your-pull-requests/ If the change is claiming performance improvements, then you should have benchmarks to back it up. There are lots of examples of this #58305 (no issue), #56630 (issue). What do the performance improvements look like in your change? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello!
I've noticed that the contributing guidelines require a ticket to exist before a PR. I interpret this as you guys are not so inclined to PR's for perf. Is this the case? Do you have guidelines for what circumstances make it ok?
To provide some context for what changes I would propose, please have a look at this diff
main...TylerBurnett:aspnetcore:main
Thank you
Beta Was this translation helpful? Give feedback.
All reactions