Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move systems to PostUpdate #3

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

msvbg
Copy link
Contributor

@msvbg msvbg commented Feb 14, 2024

I'm experiencing a little bit of jitter when having the camera track an object as it moves. I believe it's because the object's transform is updated, then the pixel camera plugin systems run, and then my camera tracking system runs, causing there to be a one-frame delay before the pixel camera's transform gets updated. This PR fixes it for me.

I believe it's correct to put these systems in PostUpdate, but I could also make do with a SystemSet for these two if you prefer that.

Copy link
Owner

@doonv doonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think putting everything in PostUpdate would be better than just the camera positioning ones.

@msvbg msvbg force-pushed the move-update-transform-systems branch from edb7d16 to 4d3cd98 Compare February 15, 2024 09:18
@msvbg msvbg changed the title Move camera transform update systems to PostUpdate Move systems to PostUpdate Feb 15, 2024
@msvbg
Copy link
Contributor Author

msvbg commented Feb 15, 2024

Done!

@doonv doonv merged commit 610baee into doonv:main Feb 15, 2024
5 checks passed
@msvbg msvbg deleted the move-update-transform-systems branch February 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants