Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProofGeneral and qrhl-tool detect end of command differently. #60

Open
1 of 2 tasks
dominique-unruh opened this issue Aug 31, 2022 · 1 comment
Open
1 of 2 tasks
Assignees
Labels
Milestone

Comments

@dominique-unruh
Copy link
Owner

dominique-unruh commented Aug 31, 2022

Example: 90c0be2e9696bc1da8cebecad5752d5644119ab6 in dominique-unruh/compressed-oracle-formalization, file lemma_cr1_cr2_2.qrhl.

Problem: In case of a mix of different parens, emacs may consider an expression balanced that isn't according to qrhl-tool. Then it processes till the ., sends this to qrhl-tool. qrhl-tool sees the . inside an unfinished expression and waits for a continuation. Consequence: communication is terminally out of sync.

To solve, we should do two things:

  • Give an understandable error in this case. (I think PG never sends commands as multiline strings, so if a partial command is sent in -emacs mode, then qrhl-tool is justified in raising an error.)
  • Fix the PG recognition of end-of-command to match up parentheses exactly like qrhl-tool.
@dominique-unruh dominique-unruh self-assigned this Aug 31, 2022
@dominique-unruh dominique-unruh added this to the 0.8 milestone Sep 1, 2022
@dominique-unruh
Copy link
Owner Author

Rejecting partial commands when --emacs is given: c4cbb6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant