-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docz): dependency issues #1647
Conversation
Awesome @adbayb, I'll gonna spend some time reviewing it, because I wanna stress some tests here, but great work! So far I've seen, a couple issues are going to be fixed indeed! |
Hello @renatobenks 👋 , any update on this? 🙏 |
I'll be finishing some tests today, but once it's done, let's merge it, is that sounds good? |
Sounds good, thank you @renatobenks 🙏 |
Any news @renatobenks ? |
Sorry for the big delay here, but I'm managing a new release for this one. I just need to ensure a few things first with @pedronauck, once I'm still not so sure about removing a few dependencies, even though it seems a good idea. But in general, so far so good in all my tests (which we need to automate ASAP from now on), and also, it'll be a great contribution for us all! Thank you a lot @adbayb for the heads up on here 🙂 |
hey @adbayb, are you willing to revert the removed dependencies? Let me know, because if not so, we could merge it right away, and right after that, evaluate those dependencies better before launching a new version. Otherwise, we'd be able to launch a new patch version, just after emerging this one. But in both cases, we wanna merge this PR. |
Hello @renatobenks 👋 , |
Actually, I'm concerned about the "unused" dependencies, from dev or not, but let me list all of them for you, so yeah, I'd feel more comfortable with you rolling back, to publish a new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, here follows the placed changes to rollback
@renatobenks Done 90ab65d |
@renatobenks Thank you for your review. Do you plan a release soon? |
Yeap, I'm releasing today a new alpha version to the next patch, Let us know if you have any issues towards this end. |
Thank you @renatobenks 🙏 . |
Hey @adbayb, this upcoming version it's on https://www.npmjs.com/package/docz/v/2.3.3-alpha.0 (https://github.com/doczjs/docz/tree/v2.3.3-alpha.0), still as alpha because I would like to get some people's feedback about how it goes, before launching it as a final patch, so please, let me know how it moves, that I'll be making some extra work for validation from here as well. |
Thanks @renatobenks , I've tested the alpha release: it works just fine in our company codebase 🚀 |
This is a lovely patch @adbayb, thank you for contributing it! The Thanks again ❤️ |
We're about to release a new alpha version to that patch because I found a significant problem for those who are not using typescript and have it as not enabled. |
Description
A PR to address several high priority issues. It been tested by emulating new npm release through a local registry (please note that if you found several package version updates in some commits: it's totally normal and I've cleaned all tested version metadata to prepare a future release through this commit https://github.com/adbayb/docz/commit/24027115300b9b79d1811558044fb71357bd9fc5).
However, @renatobenks It could be great if you can publish a new alpha version to let issue authors confirms their issue resolution 😄
Main updates (fixes):
repository
field inpackage.json
#1635 via https://github.com/adbayb/docz/commit/5f5a5d08efbad69616a38446202e06baa12812b2I've fixed the
get-pkg-repo
to prevent incrementing to the broken patch version (hotfix docz side until a clean fix is doneget-pkg-repo
side)gatsby
by preventing empty argument via https://github.com/adbayb/docz/commit/40dead8e84b643a21482a2531143aeb69431d694👉 Some other issue reporting might be solved as well (I have not tested other issue resolution).
Other updates (chore):
Opportunities (for future PRs)
peerDependencies
to accept newer version range