Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page parsing for command line usage #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xavriley
Copy link

@xavriley xavriley commented May 3, 2015

This fixes the --page argument to work as described in the
documentation when using docsplit from the command line. Users can now
specify page ranges 5-15, comma separated lists 1,5,7, single pages
3 or combinations of these e.g. 3-5,7,8,12-15

The options parser was previously passing through a String where an
Array was expected internally. This was not an issue when using the gem directly
from Ruby, only when using the command line.

This includes a command_line unit test to exercise the new page number parser.

This fixes the `--page` argument to work as described in the
documentation when using docsplit from the command line. Users can now
specify page ranges `5-15`, comma separated lists `1,5,7`, single pages
`3` or combinations of these e.g. `3-5,7,8,12-15`

The options parser was previously passing through a String where an
Array was expected internally. This was not an issue when using the gem directly
from Ruby, only when using the command line.

This includes a command_line unit test to exercise the new page number parser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant