Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sluggable] Use public property instead of deprecated array access #2925

Closed

Conversation

odolbeau
Copy link

This property is already available in doctrine/orm 2.14.0 which is the lowest supported version (see here) so we can easily use it instead of the deprecated array access.

@odolbeau odolbeau changed the title Use public property instead of deprecated array access [Sluggable] Use public property instead of deprecated array access Feb 15, 2025
@mbabker
Copy link
Contributor

mbabker commented Feb 17, 2025

This one's not quite the same thing. That Embedded attribute isn't what's being read here, it's the EmbeddedClassMapping DTO and that was introduced in 3.0 only.

@odolbeau
Copy link
Author

Oups! Sorry for the noise! 🙈
By curiosity, what's the reason to support so many versions?

@odolbeau odolbeau closed this Feb 17, 2025
@mbabker
Copy link
Contributor

mbabker commented Feb 17, 2025

ORM 2.x and 3.x are still both maintained upstream, and a lot of the code also "just works" for supporting the MongoDB ODM. So even closing the version ranges isn't exactly simplifying too much in this library's code in all honesty (especially with ORM 3.x having DTOs and the MongoDB ODM having arrays in the metadata APIs), I just did it in one PR and without flat out dropping ORM 2.x (which IMO would be a mistake and the resources aren't here to maintain two branches with support for both versions) there really isn't much else to gain.

@odolbeau
Copy link
Author

This is perfectly clear, thanks for your time and for this lib! 🙏

@odolbeau odolbeau deleted the use-public-property branch February 17, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants