commiter_date: fix github api request fallback #478
Merged
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's same API we are using |
Yes I was looking to have types handled so response schema matches. |
crazy-max
force-pushed
the
commit-date-request
branch
2 times, most recently
from
dd5bc23 to
6c97e81
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
commit-date-request
branch
from
6c97e81 to
e01ddd3
Compare
crazy-max
changed the title
|
@trim21 I'm going to get this one in if you don't mind. I prefer to avoid raw request. LGTY? |
|
it's not raw request now, it will have typing after my PR |
Still this is a generic request and using the specific method provided by the Octokit REST API client for fetching a commit provides better type safety and autocompletion |
|
ok
CrazyMax ***@***.***> 于2024年11月20日周三 00:52写道：
… it's not raw request now, it will have typing after my PR
Still this is a generic request and using the specific method provided by
the Octokit REST API client for fetching a commit provides better type
safety and autocompletion
—
Reply to this email directly, view it on GitHub
<#478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHNB3ZGR24XRBV34BY4IKL2BNUFZAVCNFSM6AAAAABSCO4CHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGI2DKNJYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #476
cc @trim21