Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails guide upgrade (part 1) #21559

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Rails guide upgrade (part 1) #21559

merged 6 commits into from
Jan 14, 2025

Conversation

igor-alexandrov
Copy link
Contributor

Description

This PR upgrades the Rails framework guide and covers the application containerization step. In the following PRs, I will update the section about deploying with Docker Compose, and add a new "Deployment with Kamal" section.

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6062444
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67855429a4dc830008d3832c
😎 Deploy Preview https://deploy-preview-21559--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn self-requested a review December 12, 2024 11:48
@igor-alexandrov
Copy link
Contributor Author

@dvdksn did you have a chance to review this?

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻 just a couple nits

content/guides/ruby/containerize.md Outdated Show resolved Hide resolved
content/guides/ruby/containerize.md Outdated Show resolved Hide resolved
content/guides/ruby/containerize.md Outdated Show resolved Hide resolved
content/guides/ruby/containerize.md Outdated Show resolved Hide resolved
content/guides/ruby/containerize.md Outdated Show resolved Hide resolved
@igor-alexandrov
Copy link
Contributor Author

Thank you, David. I resolved all your comments.

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dvdksn dvdksn merged commit d7ffb99 into docker:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants