Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/tree: Hide Content size column without containerd store #5771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Jan 24, 2025

With graph drivers, all content sizes are zero because the compressed content isn't stored.
This makes the whole column useless and wasting the terminal space.

Hide the whole column if all its values would be zero.

Before

image

After

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (5b90e0e) to head (203ce87).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5771      +/-   ##
==========================================
- Coverage   59.20%   59.17%   -0.04%     
==========================================
  Files         353      353              
  Lines       29522    29538      +16     
==========================================
  Hits        17478    17478              
- Misses      11072    11088      +16     
  Partials      972      972              

@vvoland vvoland requested a review from a team January 24, 2025 15:56
With graph drivers, all content sizes are zero because the compressed
content isn't stored.
This makes the whole column useless and wasting the terminal space.

Hide the whole column if all its values would be zero.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the image-tree-contentsize branch from 8949711 to 203ce87 Compare February 4, 2025 09:24
@vvoland vvoland marked this pull request as ready for review February 4, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants