Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: use go install for addlicense and update to v1.1.1 #64

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

crazy-max
Copy link
Member

follow-up #61 (comment)
closes #61

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.73%. Comparing base (69dd493) to head (44c80f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   67.73%   67.73%           
=======================================
  Files           5        5           
  Lines         623      623           
=======================================
  Hits          422      422           
  Misses        139      139           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the add-license-go-install branch from cd6dc44 to 44c80f1 Compare January 11, 2025 14:33
@crazy-max crazy-max requested a review from thaJeztah January 11, 2025 14:48
@crazy-max crazy-max marked this pull request as ready for review January 11, 2025 14:48
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit b6c6689 into docker:main Jan 11, 2025
6 checks passed
@crazy-max crazy-max deleted the add-license-go-install branch January 11, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants