-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertions #8
Merged
Merged
Assertions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the function osp_system_structure_from_js5() for js5-specification of OSPSystemStructure
…l be changed heavily
…ensource/sim-explorer into eis
ClaasRostock
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can consider to lift the code quality a bit in general (e.g. with regard to typing), but this is independent of your PR :-)
Great idea with the rich console, and great work!
Co-authored-by: Claas Rostock <48752696+ClaasRostock@users.noreply.github.com>
…plorer into feature/assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility to automate the process of running tests in the form of assertions after running one or more cases. Assertions will be evaluated after running the simulation and the results will be displayed by the CLI:
The format to write the assertions can be viewed from the examples, but in principle it could be checking values at a certain point in time or check that a value complies with a temporal specification inspired by Signal Temporal Logic. This is how the assertions look like in the cases file: