Improving Search Experience: Undo category grouping #1408
+24
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojdm
force-pushed
the
search/undo-category-grouping
branch
from
a0ca545 to
88fdf66
Compare
dallasread
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Qa'd fine. I'm torn on this because I like the categories.
I wonder if we could order the categories by their cumulative articles' score so that the most relevant category floats to the top. If we keep categories, I think we should the specs around query ranking be checking what the customer actually sees (NOT simply the output of the search logic).
Whatever you think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't group search results by category. Sometimes, matching articles would be pushed down the results due to the grouping.