Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Library/bin path exists before adding dll directory #590

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

daara-s
Copy link
Contributor

@daara-s daara-s commented Oct 16, 2024

Fixes #589, where lib loading breaks if Library/bin doesn't exist.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (cffe894) to head (795ce90).
Report is 6 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #590      +/-   ##
============================================
- Coverage     84.88%   84.69%   -0.19%     
============================================
  Files            77       77              
  Lines          6743     6745       +2     
  Branches        531      531              
============================================
- Hits           5724     5713      -11     
- Misses         1019     1032      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcho3 hcho3 merged commit 469fc78 into dmlc:mainline Oct 17, 2024
18 of 19 checks passed
@hcho3
Copy link
Collaborator

hcho3 commented Oct 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLL loading fails when using pyenv and poetry on Windows
2 participants