Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Cooperative Minibatching hetero bug fixes. #7821

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Oct 11, 2024

Description

Towards #7273.

Fixing bugs in the hetero implementation of the Cooperative Minibatching code path that arised when debugging #7807.

NOTE: There is still an accuracy problem which I am working on. There will be at least one more bug fix PR.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs October 11, 2024 18:23
@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Oct 11, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

Commit ID: bec6f17

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

Commit ID: 01b77dc

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

Commit ID: 20a35a7

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

Commit ID: c3e8e89

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 11, 2024

Commit ID: 61ca279

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as draft October 20, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants