Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnitTest] Fix "[UnitTest] AttributeError: module 'numpy' has no attribute 'ComplexWarning'" in #7766 #7768

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

az15240
Copy link
Contributor

@az15240 az15240 commented Sep 3, 2024

Description

Fix #7766

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

Commented out a line that will cause AttributeError: module 'numpy' has no attribute 'ComplexWarning'.

@az15240 az15240 requested a review from Rhett-Ying September 3, 2024 09:31
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 3, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 3, 2024

Commit ID: f04d9ef0bd06b9695b82251e229ea3f75d8b3356

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

re-name the title to be more meaningful.

@Rhett-Ying
Copy link
Collaborator

does this issue happen since numpy 2.0?

@az15240 az15240 changed the title [UnitTest] Fix #7766 [UnitTest] Fix UnitTest AttributeError in #7766 Sep 4, 2024
@az15240
Copy link
Contributor Author

az15240 commented Sep 4, 2024

It now worked for np.exceptions.ComplexWarning.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2024

Commit ID: 344c52bf31a2e09ceb4a02b27668cf0cc3c0037c

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

can we safely remove that line?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2024

Commit ID: 663c0e2

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@az15240
Copy link
Contributor Author

az15240 commented Sep 4, 2024

can we safely remove that line?

No, this warning is still raised. I think this is the final version and we can safely close the PR.

@az15240 az15240 changed the title [UnitTest] Fix UnitTest AttributeError in #7766 [UnitTest] Fix "[UnitTest] AttributeError: module 'numpy' has no attribute 'ComplexWarning'" in #7766 Sep 4, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2024

Commit ID: 48230b21e5be03e28ab55457a19ffde6ff59e104

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 48f47d5 into master Sep 4, 2024
2 checks passed
@Rhett-Ying Rhett-Ying deleted the stanyang_unittest branch September 4, 2024 08:33
lijialin03 pushed a commit to lijialin03/dgl that referenced this pull request Jan 6, 2025
…ibute 'ComplexWarning'" in dmlc#7766 (dmlc#7768)

Co-authored-by: Stanley Yang <stanyang@amazon.com>
Co-authored-by: Muhammed Fatih BALIN <m.f.balin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UnitTest] AttributeError: module 'numpy' has no attribute 'ComplexWarning'
4 participants