-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing problem with complex numbers appearing in the lap_pe
function.
#6925
Conversation
…ian positional encoding) function.
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Description
As I could see from
test_nn.py::test_dgn_conv[16-2.5-scalers0-aggregators0-16-16]
, the complex numbers can appear inlap_pe
in both cases, whenk + 1 < n - 1
is TRUE or FALSE. Therefore, converting them to a real number should be done for both cases.By doing this, we will resolve the following warning and potential crash in NN code
Checklist
Please feel free to remove inapplicable items for your PR.
Changes