Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.17 warning about function call without parens #58

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

michallepicki
Copy link
Contributor

In 5f45b8b I've fixed a warning about invoking a function without parentheses. It shows at run-time and looks like this:

warning: using map.field notation (without parentheses) to invoke function TableRex.Renderer.Text.default_options() is deprecated, you must add parentheses instead: remote.function()
  (table_rex 4.0.0) lib/table_rex/table.ex:267: TableRex.Table.render/2
  (table_rex 4.0.0) lib/table_rex/table.ex:280: TableRex.Table.render!/2

Copy link
Owner

@djm djm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@djm djm merged commit e744f68 into djm:main Jun 3, 2024
4 checks passed
@djm
Copy link
Owner

djm commented Jun 3, 2024

Thanks very much @michallepicki, will go out in next release.

@michallepicki michallepicki deleted the 24-06-02-fix-1-17-warnings branch June 3, 2024 16:51
@michallepicki michallepicki restored the 24-06-02-fix-1-17-warnings branch June 3, 2024 16:51
@michallepicki michallepicki deleted the 24-06-02-fix-1-17-warnings branch June 10, 2024 20:19
@axelson axelson mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants