Skip to content

Commit

Permalink
v1.0.0 Initial release. Fixed github version check.
Browse files Browse the repository at this point in the history
  • Loading branch information
djdookie committed Jan 21, 2017
1 parent 47028a2 commit df0c73d
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions Advisor/Services/GitHub.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ public static async Task<GithubRelease> CheckForUpdate(string user, string repo,
{
var latest = await GetLatestRelease(user, repo);

// tag needs to be in strict version format: e.g. 0.0.0
Version v = new Version(latest.tag_name);
// tag needs to be in strict version format: e.g. 0.0.0
//Version v = new Version(latest.tag_name);
Version v = new Version(latest.tag_name.TrimStart('v'));

// check if latest is newer than current
if (v.CompareTo(version) > 0)
// check if latest is newer than current
if (v.CompareTo(version) > 0)
{
return latest;
}
Expand Down

0 comments on commit df0c73d

Please sign in to comment.