Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Fix incorrect pluralization of model name in admin #1739

Open
bmispelon opened this issue Nov 15, 2024 · 3 comments
Open

[aggregator] Fix incorrect pluralization of model name in admin #1739

bmispelon opened this issue Nov 15, 2024 · 3 comments
Labels
bug good first issue Good for newcomers python Pull requests that update Python code

Comments

@bmispelon
Copy link
Member

On the admin page, the name of the aggregator.LocalDjangoCommunity model is listed as "Local django communitys":

Screenshot 2024-11-15 at 21-04-44 Site administration Django site admin

This should be "Local Django communities" (capital "D" for Django, and "-ies" for the plural instead of "-ys"). When fixing this, make sure the strings are marked for translation (using gettext_lazy which is already imported in the models file).

@bmispelon bmispelon added bug python Pull requests that update Python code good first issue Good for newcomers labels Nov 15, 2024
@arpan8925
Copy link

I want to work on this issue, Can you assign me the Issue ?

To solve the issue of correctly displaying the plural name for the LocalDjangoCommunity model in the Django admin, I would update the model's Meta class to include a verbose_name_plural attribute with the correct name.

arpan8925 added a commit to arpan8925/djangoproject.com that referenced this issue Nov 16, 2024
…e Solved - django#1739

Added verbose_name_plural = _("Local Django Communities") in the Meta class
@bmispelon
Copy link
Member Author

I want to work on this issue, Can you assign me the Issue ?

Hi, you don't need to be assigned to work on the issue. If you make a pull request that targets this repository, I can make a review of it.

Thanks! 🎸

@arpan8925
Copy link

Hi @bmispelon I did a pull request, Kindly Check Pull Request #1749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants