DEV: Modernise and simplify implementation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidtaylorhq
commented
Jan 4, 2024
davidtaylorhq
commented
- Lean on core ajax() function
- Lean on core fullscreen-code modal
- Add system spec
- Add linting/CI config
- Lean on core ajax() function - Lean on core fullscreen-code modal - Add system spec
CvX
approved these changes
Jan 4, 2024
| expect(page).to have_css(".fullscreen-code-modal") | ||
| expect(find(".fullscreen-code-modal code")).to have_text("**This is a test post**") | ||
| end | ||
| end |
There was a problem hiding this comment.
we gotta start working on ruby linting for themes 🥲
| @@ -0,0 +1,21 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| RSpec.describe "Raw post button", system: true do | |||
There was a problem hiding this comment.
and I wouldn't mind having a rule for using either system: true xor type: :system 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.