Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only require needed params #259

Merged
merged 3 commits into from
May 8, 2024
Merged

Only require needed params #259

merged 3 commits into from
May 8, 2024

Conversation

dangerousbeans
Copy link
Contributor

@jjaffeux
Copy link

jjaffeux commented May 7, 2024

@oblakeerickson could you look at this please?

@jjaffeux jjaffeux requested a review from oblakeerickson May 7, 2024 11:52
oblakeerickson
oblakeerickson approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@oblakeerickson oblakeerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@oblakeerickson oblakeerickson merged commit 92fac1a into discourse:main May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblakeerickson oblakeerickson oblakeerickson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangerousbeans @jjaffeux @oblakeerickson