New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Check that setting does not exist before migrate #203

Merged

nattsw merged 1 commit into main from fix-existing-setting-migration

Aug 7, 2024

Contributor

nattsw commented Aug 7, 2024 •

edited

Loading

Fix for - #202. That PR was a fix for a failed rename, but did not check if the setting may have already been overwritten manually by admins.

if the problematic migration already ran, it will result in the plugin being disabled if it was already enabled.
admins enable it manually
the new "correcting" migration in DEV: Fix migration that renamed site settings #202 would fail because the record already exists.


          DEV: Check that setting does not exist before migrate

03a3c07

tgxworld approved these changes

View reviewed changes

tyb-talks approved these changes

View reviewed changes

nattsw merged commit 9ce8f3f into main

5 checks passed

nattsw deleted the fix-existing-setting-migration branch

August 7, 2024 04:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet