Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Amend misleading test regarding remaining votes #186

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Mar 26, 2024

What is this change?

The user being tested is an admin. Admins are always should by right be TL4 in production. The default number of votes for TL4 users is 10, not 4.

@Drenmi Drenmi requested a review from martin-brennan March 26, 2024 03:21
Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but this is not the case:

Admins are always TL4 in production

Admins can be other TLs, which is the source of some of our problems.

@Drenmi Drenmi force-pushed the dev/amend-misleading-test branch from 6ad2681 to 658c0c8 Compare March 26, 2024 03:28
@Drenmi Drenmi merged commit f9654ee into main Mar 26, 2024
5 checks passed
@Drenmi Drenmi deleted the dev/amend-misleading-test branch March 26, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants