DEV: Avoid subquery in the ensure-consistency onceoff

discourse · Aug 2, 2024 · 2202986 · 2202986
1 parent 4ebcd11
commit 2202986
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/db/post_migrate/20240711102255_ensure_consistency.rb b/db/post_migrate/20240711102255_ensure_consistency.rb
@@ -27,7 +27,9 @@ def up
     # delete votes associated with no user
     DB.exec(<<~SQL)
       DELETE FROM topic_voting_votes
-      WHERE user_id NOT IN (SELECT id FROM users)
+      USING topic_voting_votes tvv
+      LEFT JOIN users u ON tvv.user_id = u.id
+      WHERE u.id IS NULL;
     SQL
 
     # delete votes associated with no topics