Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update linting #71

Merged
merged 1 commit into from
Nov 20, 2024
Merged

DEV: Update linting #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions javascripts/discourse/components/search-banner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ export default class SearchBanner extends Component {
@service siteSettings;
@service currentUser;

@action
willDestroy() {
super.willDestroy(...arguments);
document.documentElement.classList.remove("display-search-banner");
}

get displayForRoute() {
const showOn = settings.show_on;
const currentRouteName = this.router.currentRouteName;
Expand Down Expand Up @@ -62,10 +68,4 @@ export default class SearchBanner extends Component {
// but we need it for backwards compatibility
document.documentElement.classList.add("display-search-banner");
}

@action
willDestroy() {
super.willDestroy(...arguments);
document.documentElement.classList.remove("display-search-banner");
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"devDependencies": {
"@discourse/lint-configs": "2.0.1",
"@discourse/lint-configs": "2.2.1",
"ember-template-lint": "6.0.0",
"eslint": "9.14.0",
"prettier": "2.8.8"
Expand Down
23 changes: 18 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.