DEV: This line doesn't do anything #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:float isn't a recognized option, it just gets interpreted as string, which is the default. It shouldn't be registering fields, which are global, based on SiteSettings, which are per site anyway.
danielwaterworth
force-pushed
the
remove-custom-field-register-line
branch
from
e623361 to
ff38169
Compare
CvX
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:float isn't a recognized option, it just gets interpreted as string, which is the default, and it shouldn't be registering fields, which are global, based on SiteSettings, which are per site anyway.