FEATURE: chat integration and usability tweaks #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtread
force-pushed
the
main
branch
4 times, most recently
from
f8537fd to
e6c8e71
Compare
jacobtread
changed the title
Added integration with Discourse Chat to allow creating a link within the options of a chat window Open plain meeting links in a new browser tab rather than overwriting the current tab Added settings for the new chat button integration Separated template from javascript for better maintainability Added new settings for choose the default options in regards to iframes
jjaffeux
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
orhelpers didn't seem to work with it)Discourse Chat Integration
This changes adds an integration into the Discourse Chat feature adding a button to the chat options for allowing creating meeting links within the chat channels (two variants "dropdown" and "inline" from a new setting):
The button opens the same window (just with the additional options disabled), since I couldn't seem to find a way to get the chat feature to support the
[wrap][/wrap]bbcode without looking into it too much further, so in this case the meeting links are in plain text rather than formatted as buttons:Pressing "Insert" then inserts the meeting link into the current draft message:
The above chat integration can be toggled with a setting and has another setting for choosing the position of the button.
Link open in new tab
This also a change, making it so normal meeting links that are not using the iframe option, open in a new tab rather than redirecting the current tab.
Additional configuration
I've also added an additional three new settings related to the iframes:
hide iframe buttons: Controls whether the settings for desktop and mobile iframes are shown to user
default mobile iframe: Controls the default value for the mobile iframe setting
default desktop iframe: Controls the default value for the mobile iframe setting