FEATURE: Add option to lock leaderboard view to default period #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3lase
commented
Jan 2, 2025
admin/assets/javascripts/admin/components/admin-edit-leaderboard.gjs
Outdated
Show resolved
Hide resolved
For some leaderboards, filtering by time period might be unsuitable. This change introduces the option to disable the period chooser in the UI.
s3lase
force-pushed
the
feature/option-to-disable-period-chooser
branch
from
c7942a8 to
17cd9db
Compare
s3lase
commented
Jan 3, 2025
Comment on lines
+163
to
+170
| <form.Field | ||
| @name="period_filter_disabled" | ||
| @title={{i18n "gamification.leaderboard.period_filter_disabled"}} | ||
| @showTitle={{false}} | ||
| as |field| | ||
| > | ||
| <field.Checkbox @value={{field.value}} /> | ||
| </form.Field> |
There was a problem hiding this comment.
Is there a clean way to achieve an inline label with the checkbox without breaking out of form-kit?
Setting the @showTitle argument on the field generates the following, but it lacks the optional tag and does not match the styling of a standard form label. Could I style it myself? Yes! But I wanted to confirm whether this isn’t possible out of the box first.
There was a problem hiding this comment.
@chapoi what should we do in this case?
xfalcox
approved these changes
Jan 14, 2025
|
Thanks @xfalcox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #178
For some leaderboards, filtering by time period might be unsuitable. This change introduces the option to disable the period chooser in the UI.