From 1321ece511b8d7b8dc48cfc83089f564259a2cba Mon Sep 17 00:00:00 2001
From: Martin Brennan <mjrbrennan@gmail.com>
Date: Fri, 7 Feb 2025 09:42:51 +1000
Subject: [PATCH] FIX: N1 on group flair_url (#185)

When loading the gamification plugin, we are also
loading all groups for the site, which can load
an upload based on flair_type for the group.
We need to include the flair_upload record
to avoid N1s
---
 plugin.rb | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/plugin.rb b/plugin.rb
index 3f4e4ec..df735a4 100644
--- a/plugin.rb
+++ b/plugin.rb
@@ -88,10 +88,13 @@ module ::DiscourseGamification
       gamification_recalculate_scores_remaining:
         DiscourseGamification::RecalculateScoresRateLimiter.remaining,
       gamification_groups:
-        Group.all.map { |g| BasicGroupSerializer.new(g, root: false, scope: self.scope).as_json },
+        Group
+          .includes(:flair_upload)
+          .all
+          .map { |group| BasicGroupSerializer.new(group, root: false, scope: self.scope).as_json },
       gamification_leaderboards:
-        DiscourseGamification::GamificationLeaderboard.all.map do |l|
-          LeaderboardSerializer.new(l, root: false).as_json
+        DiscourseGamification::GamificationLeaderboard.all.map do |leaderboard|
+          LeaderboardSerializer.new(leaderboard, root: false).as_json
         end,
     }
   end