UX: clarify the need for authorized extension #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking `attach_csv` in the `Schedule a PM with Data Explorer results` automation script, `csv` has to be added to the list of authorized extensions in the site settings.
ZogStriP
reviewed
Dec 9, 2024
ah yes good idea, forgot I added this few months ago |
ZogStriP
reviewed
Dec 9, 2024
plugin.rb
Outdated
| field :attach_csv, | ||
| component: :boolean, | ||
| validator: ->(attach_csv) do | ||
| if attach_csv && !SiteSetting.authorized_extensions.split("|").include?("csv") |
There was a problem hiding this comment.
I think we also need to handle the * which allows for "all" extensions.
There was a problem hiding this comment.
oh didn't know we do this...
There was a problem hiding this comment.
@ZogStriP ok I added the * case thanks
ZogStriP
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking
attach_csvin theSchedule a PM with Data Explorer resultsautomation script,
csvhas to be added to the list of authorized extensions in the site settings.